Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various: Ensure WP CLI is defined before extending #23207

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Mar 2, 2022

After #23039 we are attempting to load all autoloaded files upon upgrade to we don't have mid-deploy fatals like we've had in the past. But, this is creating an issue since the Search package's CLI class is now being loaded without WP CLI being present.

Changes proposed in this Pull Request:

  • Ensures WP CLI is present before extending the class. This is helpful in situations where a class is autoloaded without a gate.

Jetpack product discussion

p1646255328527279-slack-CBG1CP4EN

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Not real sure. Install this on a test site, then have an upgrade routiene to a newer version than what is produced by this patch I suppose.

@kraftbj kraftbj requested review from a team as code owners March 2, 2022 21:20
@kraftbj kraftbj added [Pri] BLOCKER [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Bug When a feature is broken and / or not performing as intended labels Mar 2, 2022
@kraftbj kraftbj self-assigned this Mar 2, 2022
@github-actions github-actions bot added [Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Beta For serving live branches and the beta versions. https://github.com/automattic/jetpack-beta [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Mar 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Beta plugin:

  • Next scheduled release: April 5, 2022.
  • Scheduled code freeze: March 28, 2022.

Jetpack plugin:

  • Next scheduled release: April 5, 2022.
  • Scheduled code freeze: March 29, 2022.

@kraftbj kraftbj enabled auto-merge (squash) March 2, 2022 21:34
@samiff samiff self-requested a review March 2, 2022 21:37
@samiff samiff added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 2, 2022
@kraftbj kraftbj merged commit a6b7c0b into master Mar 2, 2022
@kraftbj kraftbj deleted the update/cli-classes branch March 2, 2022 21:41
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 2, 2022
@samiff samiff added this to the jetpack/10.8 milestone Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Beta For serving live branches and the beta versions. https://github.com/automattic/jetpack-beta [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] BLOCKER [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants