Sharing: Check if label value is set before to display it #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For more details, check the original trac ticket: http://plugins.trac.wordpress.org/ticket/1974
|
Would it be better to default it to an empty string up above? |
|
I believe we always want to default to "Share this:" or its i18n equivalent, never to an empty string, but I might be misunderstanding your question? |
|
@jeherve I think that is what @georgestephanis was getting at. Another update that needs to happen to this though is the label for the front end display. This currently only takes care of the backend management page. |
ghost
assigned …t end" This reverts commit 95e0506.
lezama
added a commit
that referenced
this pull request
Mar 5, 2014
Sharing: Check if label value is set before to display it
|
I asked Jeremy to revert the last commit as it wasn't necessary, the same check is done in https://github.com/Automattic/jetpack/blob/master/modules/sharedaddy/sharing-service.php#L279 |
kraftbj
pushed a commit
that referenced
this pull request
Jan 12, 2021
Jetpack Beta: Bug fixes and a new start
jeherve
added a commit
that referenced
this pull request
Jun 18, 2021
leogermani
pushed a commit
that referenced
this pull request
Aug 12, 2022
Only preload public posts; resolves #17
leogermani
pushed a commit
that referenced
this pull request
Aug 12, 2022
tbradsha
pushed a commit
that referenced
this pull request
Apr 17, 2024
Add Twitter logo with roundrect
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more details, check the original trac ticket:
http://plugins.trac.wordpress.org/ticket/1974