Photon: Remove broken support for HTML4 img percentage width/height #17300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempts to support percentages go back to at least 2012, but have never actually implemented HTML4's semantics where a percentage width/height is relative to the containing element or viewport. Instead they were using a feature of the Photon scaler that interpreted percentages relative to the image's native dimensions. And even that was broken back in 2016, when a refactor caused the Photon scaler to interpret percentages as integer pixel widths. Since there hasn't been much outcry over the breakage since 2016, and it has never worked with the HTML4 semantics people were probably expecting, and the block editor doesn't even support entering percentages for image width/height, and supplying pixel dimensions for both width and height will result in better-performing HTML output, we've decided to just drop the attempt at supporting percentage width/height. If they are supplied, they'll be ignored. This patch also cleans up a few comments elsewhere in the method, and rearranges one complicated nested if structure to be more straightforward. Fixes #9833
anomiex
added
[Feature] Photon
|
Scheduled Jetpack release: October 6, 2020. E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17300 Thank you for the great PR description! When this PR is ready for review, please apply the |
kraftbj
approved these changes
Oct 6, 2020
kraftbj
added
[Status] Ready to Merge
matticbot
added
[Status] Needs Changelog
and removed
[Status] Ready to Merge
cbuchart
added a commit
to stt-systems/stt-systems.com
that referenced
this pull request
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9833
Changes proposed in this Pull Request:
Jetpack product discussion
See #9833
Does this pull request change what data or activity we track or use?
No
Testing instructions:
<img>tag with percentage values for width and/or height.Proposed changelog entry for your changes:
<img>tag. This hasn't worked correctly since 2016, and even before that did not follow HTML4 semantics."?