Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore legacy publicize ui #13241

Closed
wants to merge 4 commits into from
Closed

Conversation

gravityrail
Copy link
Contributor

WIP experiment.

cc @jeffgolenski

@gravityrail gravityrail requested a review from a team August 16, 2019 17:54
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello gravityrail! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D31639-code before merging this PR. Thank you!

@gravityrail gravityrail added [Status] Needs Design [Feature] Publicize Now Jetpack Social, auto-sharing labels Aug 16, 2019
@jetpackbot
Copy link

jetpackbot commented Aug 16, 2019

Warnings
⚠️ "Testing instructions" are missing for this PR. Please add some
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 90a88e7

@lezama
Copy link
Contributor

lezama commented Aug 16, 2019

@gravityrail We are seeing the same tests failing in #13230, it seems something deep in core master.

@jeffgolenski
Copy link
Member

@gravityrail I'll give this a test once the checks pass and it shows up in the beta app! FYI, I'm AFK until wednesday though.

@gravityrail gravityrail added the DO NOT MERGE don't merge it! label Aug 19, 2019
@gravityrail
Copy link
Contributor Author

@jeffgolenski tests fixed, let me know when you've taken a look. I'm interested to know if we can give this old UI a coat of paint so it fits in with modern Jetpack

@gravityrail
Copy link
Contributor Author

cc @oskosk who was also pinged on #12937

Related: #12929

@jeffgolenski
Copy link
Member

The functionality of the connections seems to work just fine (tested with linkedin). But we'll need to have a larger dicussion around overall UX / UI to bring this up to speed in 2019!

@stale
Copy link

stale bot commented Nov 19, 2019

This PR has been marked as stale. This happened because:

  • It has been inactive in the past 3 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this PR has clear testing instructions, is it up to date with master, and it is still valid. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Nov 19, 2019
@kraftbj kraftbj closed this Apr 28, 2020
@kraftbj kraftbj deleted the fix/restore-publicize-ui branch April 28, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants