AMP: check if the class exists before to use it #12139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: May 7, 2019. |
Summary: After adding the AMP compat file that ships with Jetpack (this was done in D22313, D26814, D26819, D26921, and D26928), let's start using this class. This replaces D22154 and D23501, and allows us to start syncing any future changes that would rely on the Jetpack_AMP_Support class. Related Jetpack PRs: - #10945 - #11195, which reverted some of the changes in the PR above. - #12054 - #12053 - #12026 Discussion: - https://[private link] We'll need to test for issues like the ones that popped up on Jetpack at the time: #11169 We will also need to account for the fact that WordPress.com does not run the latest version of the AMP plugin. It runs an old version (0.6.2 vs. the current version on W.org 1.0.2), with its own version of some of the compatibility fixes that come with the class we've added (see [[ https://[private link].php | here ]]) and needs to be updated as per the discussions here: - https://[private link] (D14521) - https://[private link] Test Plan: * Create a post with a gallery * Add a Facebook sharing button to that post. * Try Liking that post. * Comment on one of the images in the gallery. * Load the post in an AMP view, and repeat the steps below. In all cases: - You should not see any js errors in the browser console. - You should not get any PHP notices in your debug log. Reviewers: zinigor Tags: #touches_jetpack_files Differential Revision: D26821-code This commit syncs r190790-wpcom.
jeherve
force-pushed
the
fusion-sync/jeherve/r190790-wpcom-1556114445
branch
from
2bfc1c5 to
d4dfe35
Compare
jeherve
added
[Status] Needs Review
jeherve
added a commit
that referenced
this pull request
Apr 24, 2019
This is a follow-up to #12139 for more files in sync with WordPress.com.
kraftbj
approved these changes
Apr 24, 2019
kraftbj
added
[Status] Ready to Merge
jeherve
added a commit
that referenced
this pull request
Apr 24, 2019
This is a follow-up to #12139 for more files in sync with WordPress.com.
|
Agreed. Once the requirement to check is gone on WordPress.com, I'll come back and simplify things again. |
matticbot
added
[Status] Needs Changelog
and removed
[Status] Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D26821-code
This commit syncs r190790-wpcom.
Changes proposed in this Pull Request:
Jetpack_AMP_Supportis not yet in use on WordPress.com, so we need to check if the class exists before to use it, on all files that are in sync with WordPress.com.Testing instructions:
In all cases:
Proposed changelog entry for your changes: