Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jsx highlighting to .js files #11634

Closed
wants to merge 1 commit into from

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Mar 20, 2019

cc: @simison

Details in Automattic/wp-calypso#28459, although apparently has stopped working in the interim.

@sirreal sirreal self-assigned this Mar 20, 2019
@sirreal sirreal requested a review from a team March 20, 2019 21:41
@jetpackbot
Copy link

Warnings
⚠️ "Testing instructions" are missing for this PR. Please add some
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 23e807f

@sirreal
Copy link
Member Author

sirreal commented Mar 21, 2019

I think this method of getting JSX highlighting in .js has broken.

Following along at github-linguist/linguist#3677

@simison
Copy link
Member

simison commented Mar 21, 2019

Also interesting: github-linguist/linguist#4359 (comment)

@simison
Copy link
Member

simison commented Mar 21, 2019

The file would need to be added to svnignore

@sirreal
Copy link
Member Author

sirreal commented Apr 11, 2019

This seems to have stopped working. Closing.

@sirreal sirreal closed this Apr 11, 2019
@sirreal sirreal deleted the add/js-jsx-syntax-highlighting branch April 11, 2019 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants