Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcodes: Clean up Crowdsignal oEmbed regex #11540

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Shortcodes: Clean up Crowdsignal oEmbed regex #11540

merged 1 commit into from
Mar 12, 2019

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Mar 11, 2019

Jetpack is adding a couple of oEmbeds regexes that are already included by Core.

Note survey.fm is included in Core, but the regex doesn't include subdomains, so this needs to stay until https://core.trac.wordpress.org/ticket/46467 is in a minimum version of WP.

Changes proposed in this Pull Request:

  • Clean up a couple of duplicate entries.

Testing instructions:

Proposed changelog entry for your changes:

  • Update CrowdSignal regex.

@kraftbj kraftbj added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Shortcodes / Embeds [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 11, 2019
@kraftbj kraftbj requested a review from a team March 11, 2019 19:14
@kraftbj kraftbj added this to the 7.2 milestone Mar 11, 2019
@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 2, 2019.
Scheduled code freeze: March 26, 2019

Generated by 🚫 dangerJS against 3016eca

zinigor
zinigor approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at Core files, this makes sense, thanks!

@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 12, 2019
@kraftbj kraftbj merged commit 880c3b3 into master Mar 12, 2019
@kraftbj kraftbj deleted the remove/duplicate-oembeds branch March 12, 2019 14:01
@kraftbj kraftbj removed [Status] Ready to Merge Go ahead, you can push that green button! [Status] Needs Changelog labels Mar 22, 2019
@jeherve jeherve mentioned this pull request Mar 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zinigor zinigor zinigor approved these changes

Assignees
No one assigned
Labels
[Feature] Shortcodes / Embeds [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
4 participants
@kraftbj @jetpackbot @zinigor @matticbot