Adds unit tests and is_module_active method to SAL. #11010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zinigor
added
[Status] Needs Review
|
D22570-code. (newly created revision) |
This is automated check which relies on |
lezama
previously approved these changes
Dec 20, 2018
zinigor
added
[Status] Ready to Merge
mdawaffe
reviewed
Dec 20, 2018
| @@ -96,6 +96,14 @@ function get_jetpack_modules() { | |||
| return null; | |||
| } | |||
|
|
|||
| function is_module_active( $module ) { | |||
| if ( is_user_member_of_blog() ) { | |||
There was a problem hiding this comment.
Why do we need the membership check here?
ghost
removed
the
[Status] Ready to Merge
lezama
reviewed
Dec 20, 2018
| @@ -89,11 +89,11 @@ function after_render_options( &$options ) { | |||
| } | |||
|
|
|||
| function get_jetpack_modules() { | |||
| if ( is_user_member_of_blog() ) { | |||
There was a problem hiding this comment.
if we remove the check from here we will want to add it in json-endpoints/class.wpcom-json-api-get-site-endpoint.php
lezama
approved these changes
Dec 21, 2018
|
This is already deployed on the other side. Thanks, Miguel! |
zinigor
added
the
[Status] Ready to Merge
ghost
removed
the
[Status] Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to synchronize code between Jetpack and WordPress.com better one of the little pieces we needed was the
is_module_activemethod present in the Site Abstraction Layer. This change adds it as well as enforcing its existence in all extending classes.Changes proposed in this Pull Request:
is_module_activemethod for SAL Sites.Testing instructions:
Proposed changelog entry for your changes:
This blocks #10945