Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open Graph: change og:type of home and front page queries to website #11

Merged
merged 1 commit into from
Dec 21, 2013
Merged

Open Graph: change og:type of home and front page queries to website #11

merged 1 commit into from
Dec 21, 2013

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Dec 18, 2013

Props @niallkennedy

For more details, see original trac ticket:
http://plugins.trac.wordpress.org/ticket/1946

@georgestephanis
Copy link
Member

@niallkennedy - would it be better to set it to 'website' if it's a page, but 'blog' if it's an archive page?

@niallkennedy
Copy link
Contributor

The og:type value used in a broad library should be a type supported by the Open Graph protocol standard or Facebook-supported global object types. Individual sites may have a more specific og:type scoped to their usage (e.g. giltgroupe:product) and will look to override in a filter.

An og:type of blog is not a valid type based on the current spec but consuming agents may map old types to new types. An og:type of website is the default.

@georgestephanis
Copy link
Member

Good enough for me! 👍

georgestephanis added a commit that referenced this pull request Dec 21, 2013
@georgestephanis
Merge pull request #11 from jeherve/1946-trac
ae3d8ee 
correct the homepage OG tag to `website` instead of `blog`
props @niallkennedy
@georgestephanis georgestephanis merged commit ae3d8ee into Automattic:master Dec 21, 2013
@richardmtl richardmtl mentioned this pull request Dec 22, 2013
Closed
@jeherve jeherve deleted the 1946-trac branch December 30, 2013 11:23
@BFTrick BFTrick mentioned this pull request Nov 18, 2016
Closed
jeherve pushed a commit that referenced this pull request Jun 18, 2021
@lezama @jeherve
DNA: Use Jetpack autoloader (#11)
56c9041 
* Use Jetpack autoloader to load all packages
* Use `wp_kses` over the notice string.
* remove unnecesssary call to plugin_basename
* use plugin_dir_path
* update composer lock
* update composer
@knutsp knutsp mentioned this pull request Apr 6, 2022
Open
@ultra2extreme ultra2extreme mentioned this pull request Jan 30, 2023
Closed
@sc0ttkclark sc0ttkclark mentioned this pull request Aug 2, 2023
Closed
@cliffordp cliffordp mentioned this pull request Oct 20, 2023
Closed
@helenaartmann helenaartmann mentioned this pull request Dec 13, 2023
Closed
tbradsha pushed a commit that referenced this pull request Apr 17, 2024
@enejb
Merge pull request #11 from Automattic/update/react-folder-build
dbcc00f 
React: Update the react component output to be more consistant and fix typos
@gogdzl gogdzl mentioned this pull request May 13, 2024
Merged
3 tasks
@rob-kne rob-kne mentioned this pull request May 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Feature] Publicize Now Jetpack Social, auto-sharing [Feature] Sharing Post sharing, sharing buttons [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeherve @georgestephanis @niallkennedy