Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VideoPress: Fatal error with paid posts #34728

Closed
richards1052 opened this issue Dec 20, 2023 · 7 comments · Fixed by #34723
Closed

VideoPress: Fatal error with paid posts #34728

richards1052 opened this issue Dec 20, 2023 · 7 comments · Fixed by #34723
Assignees
@chrisfromthelc
Labels
[Package] VideoPress [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] High [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@richards1052
Copy link

Impacted plugin

Jetpack

Quick summary

Jetpack restricts access to the homepage. Any links to post pages from the homepage generate a "critical error" message. Disabling Jetpack restores full access. THis is the error log my web host sent me:

I see Jetpack errors in the php log:
[17-Dec-2023 11:11:05 UTC] PHP Fatal error: Uncaught Error: Class ‘Automattic\Jetpack\Extensions\Premium_Content\Subscription_Service\Token_Subscription_Service’ not found in /home/virtualmin/richardsilverstein.com/public_html/wp-content/plugins/jetpack/modules/subscriptions/subscribe-modal/class-jetpack-subscribe-modal.php:193
Stack trace: 0 /home/virtualmin/richardsilverstein.com/public_html/wp-content/plugins/jetpack/modules/subscriptions/subscribe-modal/class-jetpack-subscribe-modal.php(62): Jetpack_Subscribe_Modal->should_user_see_modal() 1 /home/virtualmin/richardsilverstein.com/public_html/wp-includes/class-wp-hook.php(324): Jetpack_Subscribe_Modal->enqueue_assets() 2 /home/virtualmin/richardsilverstein.com/public_html/wp-includes/class-wp-hook.php(348): WP_Hook->apply_filters() 3 /home/virtualmin/richardsilverstein.com/public_html/wp-includes/plugin.php(517): WP_Hook->do_action() 4 /home/virtualmin/richardsilverstein.com/public_html/wp-includes/script-loader.php(2262): do_action() 5 /home/virtualmin/richardsilverstein.com/public_html/wp-i in /home/virtualmin/richardsilverstein.com/public_html/wp-content/plugins/jetpack/modules/subscriptions/subscribe-modal/class-jetpack-subscribe-modal.php on line 193

Steps to reproduce

go to homepage
click on any post link on the homepage
instead of brining up the post, you see a "criticial error" message

A clear and concise description of what you expected to happen.

On clicking the post link I expected the post to display instead of the error

What actually happened

critical error msg

Impact

All

Available workarounds?

No and the platform is unusable

Platform (Simple and/or Atomic)

Self-hosted

Logs or notes

Happens on all browsers
@richards1052 richards1052 added [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Dec 20, 2023
@github-actions github-actions bot added the [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack label Dec 20, 2023
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] BLOCKER labels Dec 20, 2023
@jeherve jeherve mentioned this issue Dec 20, 2023
Merged
3 tasks
@jeherve jeherve moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Dec 20, 2023
@jeherve
Copy link
Member

jeherve commented Dec 20, 2023

Thanks for the report, and sorry for the trouble! We're working on a fix in #34723, and will release a new version of the plugin with that fix when it's been reviewed and tested.

If you feel comfortable editing PHP files, do not hesitate to test the patch and let us know if it fixed the problem for you (the file can be found under wp-content/plugins/jetpack/jetpack_vendor/automattic/jetpack-videopress/src/class-access-control.php on your site)

@jeherve jeherve changed the title Jetpack denies access to post pages VideoPress: Fatal error with paid posts Dec 20, 2023
@sdixon194 sdixon194 reopened this Dec 20, 2023
@sdixon194
Copy link
Contributor

Reopening until the fix is out. I've cut Jetpack 12.9.2 which should fix the issue, and it's available on SVN, but the stable tag hasn't been updated yet.

@richards1052
Copy link
Author

richards1052 commented Dec 20, 2023 via email

@richards1052
Copy link
Author

richards1052 commented Dec 20, 2023 via email

@chrisfromthelc
Copy link
Contributor

chrisfromthelc commented Dec 21, 2023 •
edited
Loading

@richards1052 I believe the fix is more likely #34718. There are a few fixes concerning the Token Subscription Service class name, so it looks like perhaps the wrong issue was posted here for you.

As @jeherve mentioned, feel free to implement the fixes directly if you're comfortable doing so; otherwise, this should be out on the next update.

(edited to include correct link)

@richards1052
Copy link
Author

richards1052 commented Dec 31, 2023 •
edited
Loading

@richards1052 I believe the fix is more likely #34718. There are a few fixes concerning the Token Subscription Service class name, so it looks like perhaps the wrong issue was posted here for you.

As @jeherve mentioned, feel free to implement the fixes directly if you're comfortable doing so; otherwise, this should be out on the next update.

(edited to include correct link)

I've updated to the new version and the bug is fixed. But a Jetpack Plugin Author said in the Support forum that Jetpack site stats would be restored in the plugin update. Not only are they entirely blank, they're not recording stats since I installed the new version. So there appears to be something still amiss. Let me know if and how I should report this if this isn't the correct place.

@jeherve
Copy link
Member

jeherve commented Jan 9, 2024

I'll close this issue since the bug fix has now been shipped.

they're not recording stats since I installed the new version. So there appears to be something still amiss. Let me know if and how I should report this if this isn't the correct place.

Could you contact us via email so we can take a closer look at your stats with you?

Thank you!

@jeherve jeherve closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisfromthelc chrisfromthelc

Labels
[Package] VideoPress [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] High [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack Triaged [Type] Bug When a feature is broken and / or not performing as intended
Projects
Automattic Prioritization: The One Board ™
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix token subscription service name Automattic/jetpack
4 participants
@jeherve @richards1052 @chrisfromthelc @sdixon194