Connection: XMLRPC_Connector can never work

[mdawaffe]

b52fa91 introduced Connection Connectors.

When the site is not yet active, the XML-RPC Connector is instantiated at

jetpack/class.jetpack.php

Line 624 in 9762312

new XMLRPC_Connector( $this->connection_manager );

This adds an XML-RPC method: jetpack.verifyRegistration:

jetpack/packages/connection/src/XMLRPC_Connector.php

Lines 32 to 45 in 9762312

	/**
	* Attached to the `xmlrpc_methods` filter.
	*
	* @param array $methods The already registered XML-RPC methods.
	* @return array
	*/
	public function xmlrpc_methods( $methods ) {
	return array_merge(
	$methods,
	array(
	'jetpack.verifyRegistration' => array( $this, 'verify_registration' ),
	)
	);
	}

However, the next line in class.jetpack.php clears all existing XML-RPC methods since Jetpack_XMLRPC_Server::bootstrap_xmlrpc_methods does not filter its input but instead outputs only its own methods:

jetpack/class.jetpack-xmlrpc-server.php

Lines 86 to 94 in 9762312

	/**
	* Whitelist of the bootstrap XML-RPC methods
	*/
	function bootstrap_xmlrpc_methods() {
	return array(
	'jetpack.remoteAuthorize' => array( $this, 'remote_authorize' ),
	'jetpack.remoteRegister' => array( $this, 'remote_register' ),
	);
	}

Thus, when WordPress.com tries to use the jetpack.verifyRegistration method, it always fail, and WordPress.com always falls back to the REST Connector.

[oskosk]

Related #13084