Contact form: cannot insert a form using do_shortcode #102

jeherve · 2014-01-22T08:41:04Z

Steps to reproduce:

Edit one of your theme's template files and add a Contact form with the do_shortcode function:

<?php echo do_shortcode( "[contact-form][contact-field label='Name' type='name' required='1'/][contact-field label='Email' type='email' required='1'/][contact-field label='Website' type='url'/][contact-field label='Comment' type='textarea' required='1'/][/contact-form] " ); ?>

Load a page using this template file: the contact form is displayed.
Fill in the form, and submit it
The form is not submitted properly.

Reported in this trac ticket:
https://plugins.trac.wordpress.org/ticket/1762

jtwiest · 2014-01-25T19:09:10Z

Form only processes when it is coming from a widget or when the shortcode is in the comment.

https://github.com/Automattic/jetpack/blob/master/modules/contact-form/grunion-contact-form.php#L146-172

blobaugh · 2014-02-03T16:52:21Z

@jeherve do you have time to test this?

jeherve · 2014-02-03T17:01:36Z

@jeherve do you have time to test this?

I'm afk until next week so I wouldn't mind if you could check for me.
Thanks!

blobaugh · 2014-02-03T18:09:12Z

Whoops. You should not be checking your messages then!

aaronbazinet · 2014-07-17T23:02:48Z

Yep, I'm still having this issue. Contact form appears on page, but message doesn't send.

georgestephanis · 2014-10-09T15:48:59Z

I wonder if the best way to resolve this may be an option or custom post type or something that we store forms in by a hash of the complete shortcode. It could lead to some legacy cruft for previous versions of a shortcode, but it would ensure that we could always look up on the back-end and see what the contact form looked like.

jpswade · 2014-10-10T11:25:49Z

This issue still appears in Version 3.1.1...

georgestephanis · 2014-10-10T13:24:43Z

It's not a bug, it's an enhancement. The form contents is fished back by scanning the queried post of the page it was submitted to. Without any way of knowing what the form looked like, there's no way to accept the submission. We're considering an alternate data store, but currently it's just not feasible.

jpswade · 2014-10-10T13:38:26Z

I'm not sure I fully understand why it needs to know what the form looked like in order to store and send the message?

georgestephanis · 2014-10-10T13:44:38Z

Because how else would it know what fields to expect? Keep in mind that it does support adding of multiple fields, and we can't trust user input, as they could spoof new fields. Especially as the data gets stored in the database, and not merely emailed out.

jpswade · 2014-10-10T14:27:12Z

I understand.

I guess the solution for the time being is to use a widget instead...

clarklab · 2015-05-21T08:05:04Z

For me, the form actually sends just fine, it's just sending to the wrong address. Using do_shortcode somehow makes it ignore the "to" parameter.

The thing that has me really puzzled is how my address keeps getting the submissions. We've changed the page author, the admin contact, my user account email: I simply have no idea how it's getting my email.

lstude · 2015-05-22T18:29:31Z

As an update to @clarklab's previous comment -- we were able to use the following workaround to get our footer form to send to the proper address:

Update user's email address to wherever you want form to send:
Change the author on whatever page is linked to your broken form to the updated user (in our case, it was Home - Front Page
Form now submits to proper address

RobertShippey · 2015-07-15T11:37:45Z

@lstude I think your workaround might help me here, but my contact form is on the single template for a custom post type, so do you think I would have to change the author of every item of my custom post type to make the form work across all instances of it?

I've found the same as @clarklab, the do_shortcode function seems to make the form ignore the to parameter. Anyone else found any other ways to fix this?

…ne created in template. There's a Grunion bug that prevents using arbitrary do_shortcode() calls: Automattic/jetpack#102 git-svn-id: https://meta.svn.wordpress.org/sites/trunk/wordcamp.org@386 74240141-8908-4e6f-9713-ba540dce6ec7

…ne created in template. There's a Grunion bug that prevents using arbitrary do_shortcode() calls: Automattic/jetpack#102 git-svn-id: https://meta.svn.wordpress.org/sites/trunk/wordcamp.org/public_html/wp-content/plugins@386 74240141-8908-4e6f-9713-ba540dce6ec7

…ne created in template. There's a Grunion bug that prevents using arbitrary do_shortcode() calls: Automattic/jetpack#102 git-svn-id: https://meta.svn.wordpress.org/sites/trunk/wordcamp.org@386 74240141-8908-4e6f-9713-ba540dce6ec7 git-svn-id: https://github.com/WordPress/wordcamp.org.git@53 a64dc54a-4538-25e2-d9ce-ce57b7db7bff

…ne created in template. There's a Grunion bug that prevents using arbitrary do_shortcode() calls: Automattic/jetpack#102 git-svn-id: http://meta.svn.wordpress.org/sites/trunk/wordcamp.org@386 74240141-8908-4e6f-9713-ba540dce6ec7

…ne created in template. There's a Grunion bug that prevents using arbitrary do_shortcode() calls: Automattic/jetpack#102 git-svn-id: https://meta.svn.wordpress.org/sites/trunk/wordcamp.org@386 74240141-8908-4e6f-9713-ba540dce6ec7

stale · 2018-12-25T16:59:19Z

This issue has been marked as stale. This happened because:

It has been inactive in the past 6 months.
It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

htdat · 2019-10-24T06:34:22Z

Still the issue. Just tested with 7.9-alpha.

stale · 2020-04-23T08:16:36Z

This issue has been marked as stale. This happened because:

It has been inactive in the past 6 months.
It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

Fixes #101

The action names that we're hooking to a callback are wrong, they've changed and we haven't updated it. I've added the new ones and left the old ones for backward compability.

github-actions · 2021-07-26T00:49:05Z

This issue has been marked as stale. This happened because:

It has been inactive in the past 6 months.
It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`, etc.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@davewhitley

Drawn by @davewhitley. Closes #102.

simison · 2025-01-02T17:20:43Z

@jeherve I think we can close this issue at this point, as a wont-fix? One can use do_blocks() and modern block markup if there's a need to do something like this programmatically.

jeherve · 2025-01-06T14:21:09Z

Yes, I think it's a lot less relevant in a world of block-based widgets and the Form block being available to insert in templates in block-based themes.

jtwiest mentioned this issue Jan 25, 2014

Fixed do_shortcode error #133

Merged

jeherve closed this as completed Feb 9, 2014

georgestephanis mentioned this issue Jun 18, 2014

Contact form not sending in 'do_shortcode()' #746

Closed

rase- reopened this Jun 18, 2014

jeherve modified the milestones: 2.9 Freeze, 3.1 Freeze Jun 19, 2014

blobaugh modified the milestones: 3.2, 3.1 Freeze Jul 8, 2014

blobaugh modified the milestones: 3.2, 3.3 Aug 27, 2014

georgestephanis assigned rase- Oct 9, 2014

georgestephanis modified the milestones: vFuture, 3.3 Oct 9, 2014

jpswade mentioned this issue Oct 10, 2014

Do_shortcode only send email to author and not the email mentionned in shortcode #463

Closed

jeherve mentioned this issue Feb 27, 2015

Contact Form: add a copy of th shortcode in post_meta #1692

Merged

jeherve mentioned this issue May 22, 2015

Add Contact Form Button to Menu Bar in Mobile #2162

Closed

stale bot added the [Status] Stale label Dec 25, 2018

stale bot removed the [Status] Stale label Oct 24, 2019

jeherve mentioned this issue Oct 24, 2019

Contact Form: Required fields have blank data in received form responses #13828

Closed

stale bot added the [Status] Stale label Apr 23, 2020

ghost mentioned this issue Sep 24, 2020

Placeholder form defaults to last form created WordPress/wordcamp.org#648

Open

kraftbj added a commit that referenced this issue Jan 12, 2021

Confirm array item is present before attempting access (#102)

4a5e349

Fixes #101

kraftbj removed this from the Not Currently Planned milestone Jan 26, 2021

stale bot removed the [Status] Stale label Jan 26, 2021

jeherve pushed a commit that referenced this issue Jun 18, 2021

Fix user meta pings (#102)

ff53db9

The action names that we're hooking to a callback are wrong, they've changed and we haven't updated it. I've added the new ones and left the old ones for backward compability.

github-actions bot added the [Status] Stale label Jul 26, 2021

jeherve mentioned this issue Feb 9, 2022

FSE: Form Blocks Added To Footer Template Part Show As Shortcodes on 404 pages #22749

Closed

tbradsha pushed a commit that referenced this issue Apr 17, 2024

Include TikTok icons

7da4891

Drawn by @davewhitley. Closes #102.

tbradsha closed this as completed in abe33ba May 23, 2024

github-actions bot removed the [Status] Stale label May 23, 2024

jeherve reopened this May 23, 2024

jeherve closed this as completed Jan 6, 2025

jeherve added the [Closed] Won't Fix wontfix. This issue will not be addressed. label Jan 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Contact form: cannot insert a form using do_shortcode #102

Contact form: cannot insert a form using do_shortcode #102

jeherve commented Jan 22, 2014

jtwiest commented Jan 25, 2014

blobaugh commented Feb 3, 2014

jeherve commented Feb 3, 2014

blobaugh commented Feb 3, 2014

aaronbazinet commented Jul 17, 2014

georgestephanis commented Oct 9, 2014

jpswade commented Oct 10, 2014

georgestephanis commented Oct 10, 2014

jpswade commented Oct 10, 2014

georgestephanis commented Oct 10, 2014

jpswade commented Oct 10, 2014

clarklab commented May 21, 2015

lstude commented May 22, 2015

RobertShippey commented Jul 15, 2015

stale bot commented Dec 25, 2018

htdat commented Oct 24, 2019

stale bot commented Apr 23, 2020

github-actions bot commented Jul 26, 2021

simison commented Jan 2, 2025

jeherve commented Jan 6, 2025

Contact form: cannot insert a form using do_shortcode #102

Contact form: cannot insert a form using do_shortcode #102

Comments

jeherve commented Jan 22, 2014

jtwiest commented Jan 25, 2014

blobaugh commented Feb 3, 2014

jeherve commented Feb 3, 2014

blobaugh commented Feb 3, 2014

aaronbazinet commented Jul 17, 2014

georgestephanis commented Oct 9, 2014

jpswade commented Oct 10, 2014

georgestephanis commented Oct 10, 2014

jpswade commented Oct 10, 2014

georgestephanis commented Oct 10, 2014

jpswade commented Oct 10, 2014

clarklab commented May 21, 2015

lstude commented May 22, 2015

RobertShippey commented Jul 15, 2015

stale bot commented Dec 25, 2018

htdat commented Oct 24, 2019

stale bot commented Apr 23, 2020

github-actions bot commented Jul 26, 2021

simison commented Jan 2, 2025

jeherve commented Jan 6, 2025