My Jetpack: remove red dot from notice component (#36773)

* My Jetpack: Remove red bubble from notices * changelog
Automattic · Apr 8, 2024 · fcf3667 · fcf3667
1 parent 27e4b60
commit fcf3667
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 5 deletions.
diff --git a/projects/packages/my-jetpack/_inc/components/my-jetpack-screen/index.jsx b/projects/packages/my-jetpack/_inc/components/my-jetpack-screen/index.jsx
@@ -54,7 +54,6 @@ const GlobalNotice = ( { message, options } ) => {
 		<div
 			className={ classnames( styles.notice, {
 				[ styles[ 'bigger-than-medium' ] ]: isBiggerThanMedium,
-				[ styles[ 'is-red-bubble' ] ]: options.isRedBubble,
 			} ) }
 		>
 			<Notice hideCloseButton={ true } { ...options } actions={ actionButtons }>

diff --git a/projects/packages/my-jetpack/_inc/context/notices/noticeContext.tsx b/projects/packages/my-jetpack/_inc/context/notices/noticeContext.tsx
@@ -6,7 +6,6 @@ const defaultNotice: Notice = {
 	options: {
 		level: '',
 		priority: 0,
-		isRedBubble: false,
 	},
 };
 

diff --git a/projects/packages/my-jetpack/_inc/context/notices/types.ts b/projects/packages/my-jetpack/_inc/context/notices/types.ts
@@ -13,7 +13,6 @@ export type Notice = {
 		level: string;
 		actions?: NoticeButtonAction[];
 		priority: number;
-		isRedBubble?: boolean;
 	};
 };
 

diff --git a/projects/packages/my-jetpack/_inc/hooks/use-notification-watcher/use-bad-install-notice.ts b/projects/packages/my-jetpack/_inc/hooks/use-notification-watcher/use-bad-install-notice.ts
@@ -50,7 +50,6 @@ const useBadInstallNotice = ( redBubbleAlerts: RedBubbleAlerts ) => {
 				},
 			],
 			priority: NOTICE_PRIORITY_MEDIUM,
-			isRedBubble: true,
 		};
 
 		setNotice( {

diff --git a/...cts/packages/my-jetpack/_inc/hooks/use-notification-watcher/use-site-connection-notice.ts b/...cts/packages/my-jetpack/_inc/hooks/use-notification-watcher/use-site-connection-notice.ts
@@ -49,7 +49,6 @@ const useSiteConnectionNotice = ( redBubbleAlerts: RedBubbleAlerts ) => {
 				},
 			],
 			priority: NOTICE_PRIORITY_HIGH,
-			isRedBubble: true,
 		};
 
 		setNotice( {

diff --git a/projects/packages/my-jetpack/changelog/remove-red-bubble-logic-connection-notice b/projects/packages/my-jetpack/changelog/remove-red-bubble-logic-connection-notice
@@ -0,0 +1,4 @@
+Significance: minor
+Type: removed
+
+My Jetpack: remove red bubble from connection notice in favor of using the status of the Notice component