-
Notifications
You must be signed in to change notification settings - Fork 809
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Twitter Timeline Widget: load js asynchronously
props @jeherve see original trac ticket https://plugins.trac.wordpress.org/ticket/1775
- Loading branch information
Showing
3 changed files
with
20 additions
and
1 deletion.
There are no files selected for viewing
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b840a08
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephdau, any objection to this being merged into wpcom?
b840a08
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that very much too. So long as it's tested.
I'll never have an objection to working code making it in. :)
Hard to tell with just a diff. It's not like I authored all those and can commit to an answer off the top of my head. I inherited of them [too]. If you merge code up, I'll trust your judgement, and testing (on both platforms: jp and wpcom). All that matters is that it works, and is the same (when shared) on both platform as soon as reasonable/feasible.