AI Assistant: restrict stored state value (#34522)

* restrict stored states to 'init' and 'done' so we don't reload into half way scenarios * add changelog entry * fix misuse of ternary
Automattic · Dec 12, 2023 · a929801 · a929801
1 parent 59a2a1a
commit a929801
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/projects/plugins/jetpack/changelog/fix-ai-state-stored-issue b/projects/plugins/jetpack/changelog/fix-ai-state-stored-issue
@@ -0,0 +1,4 @@
+Significance: patch
+Type: bugfix
+
+AI Assistant: restrict stored states to init and done to prevent half way states of the block
diff --git a/projects/plugins/jetpack/extensions/blocks/ai-assistant/edit.js b/projects/plugins/jetpack/extensions/blocks/ai-assistant/edit.js
@@ -220,6 +220,11 @@ export default function AIAssistantEdit( { attributes, setAttributes, clientId,
 	}, [ promptPlaceholder, currentIndex ] );
 
 	useEffect( () => {
+		// we don't want to store "half way" states
+		if ( ! [ 'init', 'done' ].includes( requestingState ) ) {
+			return;
+		}
+
 		setAttributes( { requestingState } );
 	}, [ requestingState, setAttributes ] );