Fix the media validation notice shown even when auto conversion is en…

…abled. (#34730) Co-authored-by: Gergely Juhasz <gergely.juhasz@automattic.com>
Automattic · Dec 20, 2023 · 86d3c5b · 86d3c5b
1 parent 6d7ac79
commit 86d3c5b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/projects/js-packages/publicize-components/changelog/fix-media-validation-notice b/projects/js-packages/publicize-components/changelog/fix-media-validation-notice
@@ -0,0 +1,4 @@
+Significance: patch
+Type: fixed
+
+Fixed the media validation notice shown even when auto conversion is enabled.
diff --git a/projects/js-packages/publicize-components/src/components/form/index.js b/projects/js-packages/publicize-components/src/components/form/index.js
@@ -118,6 +118,7 @@ export default function PublicizeForm() {
 							<ValidationNotice
 								connectionsCount={ connections.length }
 								invalidConnectionIdsCount={ invalidIds.length }
+								shouldAutoConvert={ shouldAutoConvert }
 							/>
 						) ) }
 				</>

diff --git a/projects/js-packages/publicize-components/src/components/form/validation-notice.tsx b/projects/js-packages/publicize-components/src/components/form/validation-notice.tsx
@@ -6,13 +6,15 @@ import Notice from '../notice';
 export type ValidationNoticeProps = {
 	connectionsCount: number;
 	invalidConnectionIdsCount: number;
+	shouldAutoConvert: boolean;
 };
 
 export const ValidationNotice: React.FC< ValidationNoticeProps > = ( {
 	connectionsCount,
 	invalidConnectionIdsCount,
+	shouldAutoConvert,
 } ) => {
-	return (
+	return shouldAutoConvert ? null : (
 		<Notice type={ 'warning' }>
 			<p>
 				{ connectionsCount === invalidConnectionIdsCount