Skip to content

Commit

Permalink
Update/videopress match feature check criteria (#25691)
Browse files Browse the repository at this point in the history
* match the feature check criteria for showing upsells with the Performance -> Media components

* changelog

* only use videopress for feature check on upsells, not video-hosting since that is what the upload endpoint uses to validate

Co-authored-by: sdixon194 <steve.dixon@automattic.com>
  • Loading branch information
jgcaruso and sdixon194 authored Aug 29, 2022
1 parent 3d36395 commit 84be43c
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,8 @@ export default connect(
hasConnectedOwner: hasConnectedOwnerSelector( state ),
hasVideoPressFeature:
siteHasFeature( state, 'videopress-1tb-storage' ) ||
siteHasFeature( state, 'videopress-unlimited-storage' ),
siteHasFeature( state, 'videopress-unlimited-storage' ) ||
siteHasFeature( state, 'videopress' ),
hasVideoPressUnlimitedStorage: siteHasFeature( state, 'videopress-unlimited-storage' ),
isModuleAvailable: isModuleAvailable( state, 'videopress' ),
isOffline: isOfflineMode( state ),
Expand Down
3 changes: 1 addition & 2 deletions projects/plugins/jetpack/_inc/client/performance/media.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,7 @@ export default connect( state => {
hasVideoPressFeature:
siteHasFeature( state, 'videopress-1tb-storage' ) ||
siteHasFeature( state, 'videopress-unlimited-storage' ) ||
siteHasFeature( state, 'videopress' ) ||
siteHasFeature( state, 'video-hosting' ),
siteHasFeature( state, 'videopress' ),
hasVideoPressUnlimitedStorage: siteHasFeature( state, 'videopress-unlimited-storage' ),
hasConnectedOwner: hasConnectedOwnerSelector( state ),
isOffline: isOfflineMode( state ),
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: bugfix

Fixed the criteria for showing VideoPress upsells in the Jetpack Dashboard

0 comments on commit 84be43c

Please sign in to comment.