[not verified] VideoPress: Fix local video listed as VideoPress video (…

…#28237) * add isLocalVideo flag to VideoRow * changelog
Automattic · Jan 11, 2023 · 4d7b0fb · 4d7b0fb
1 parent d982962
commit 4d7b0fb
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 3 deletions.
diff --git a/projects/packages/videopress/changelog/fix-videopress-local-video-listed b/projects/packages/videopress/changelog/fix-videopress-local-video-listed
@@ -0,0 +1,4 @@
+Significance: patch
+Type: fixed
+
+VideoPress: Fix local video listed as VideoPress video
diff --git a/projects/packages/videopress/src/client/admin/components/video-list/index.tsx b/projects/packages/videopress/src/client/admin/components/video-list/index.tsx
@@ -11,7 +11,7 @@ import { useState } from 'react';
  */
 import { VIDEO_PRIVACY_LEVELS, VIDEO_PRIVACY_LEVEL_PRIVATE } from '../../../state/constants';
 import Checkbox from '../checkbox';
-import ConnectVideoRow, { VideoRow, Stats } from '../video-row';
+import ConnectVideoRow, { LocalVideoRow, Stats } from '../video-row';
 import styles from './style.module.scss';
 /**
  * Types
@@ -151,7 +151,7 @@ export const LocalVideoList = ( {
 					return null;
 				}
 				return (
-					<VideoRow
+					<LocalVideoRow
 						key={ `local-video-${ video.id }` }
 						id={ video.id }
 						title={ video.title }

diff --git a/projects/packages/videopress/src/client/admin/components/video-row/index.tsx b/projects/packages/videopress/src/client/admin/components/video-row/index.tsx
@@ -121,6 +121,7 @@ export const VideoRow = ( {
 	disableActionButton = false,
 	disabled = false,
 	uploadProgress,
+	isLocalVideo = false,
 }: VideoRowProps ) => {
 	const textRef = useRef( null );
 	const checkboxRef = useRef( null );
@@ -320,11 +321,17 @@ export const VideoRow = ( {
 				) }
 			</div>
 
-			<PublishFirstVideoPopover id={ id } anchor={ anchor } position="top center" />
+			{ ! isLocalVideo && (
+				<PublishFirstVideoPopover id={ id } anchor={ anchor } position="top center" />
+			) }
 		</div>
 	);
 };
 
+export const LocalVideoRow = ( props: VideoRowProps ) => {
+	return <VideoRow isLocalVideo={ true } { ...props } />;
+};
+
 export const ConnectVideoRow = ( { id, ...restProps }: VideoRowProps ) => {
 	const { isDeleting, uploading, processing, isUpdatingPoster, data, uploadProgress } = useVideo(
 		id

diff --git a/projects/packages/videopress/src/client/admin/components/video-row/types.ts b/projects/packages/videopress/src/client/admin/components/video-row/types.ts
@@ -59,6 +59,10 @@ type VideoRowBaseProps = {
 	 * Adornment to be showed after title.
 	 */
 	disableActionButton?: boolean;
+	/**
+	 * True when row is used to show a local video.
+	 */
+	isLocalVideo?: boolean;
 };
 
 type VideoPressVideoProps = VideoRowBaseProps &