Remove jetpack recommendation banners from non jetpack pages in wp-ad…

…min (#34769)

* Stop showing the recommendations banner on non-jetpack pages in wp-admin

* changelog

projects/plugins/jetpack/changelog/remove-jetpack-recommendation-banners

@@ -0,0 +1,4 @@
+Significance: minor
+Type: other
+
+Remove the recommendations banner from non-jetpack wp-admin pages

projects/plugins/jetpack/class-jetpack-recommendations-banner.php

@@ -1,6 +1,7 @@
 <?php
 /**
  * Displays the site type recommendations question as a banner.
+ * DEPRECATED in v 13.0
  *
  * @package automattic/jetpack
  */

projects/plugins/jetpack/class.jetpack-admin.php

@@ -599,22 +599,6 @@ public function should_display_jitms_on_screen( $value, $screen_id ) {
 			return false;
 		}
 
-		// Disable all JITMs on pages where the recommendations banner is displaying.
-		if (
-			in_array(
-				$screen_id,
-				array(
-					'dashboard',
-					'plugins',
-					'jetpack_page_stats',
-				),
-				true
-			)
-			&& \Jetpack_Recommendations_Banner::can_be_displayed()
-		) {
-			return false;
-		}
-
 		return $value;
 	}
 }

projects/plugins/jetpack/class.jetpack.php

@@ -753,8 +753,6 @@ private function __construct() {
 
 		add_action( 'wp_ajax_jetpack_connection_banner', array( $this, 'jetpack_connection_banner_callback' ) );
 
-		add_action( 'wp_ajax_jetpack_recommendations_banner', array( 'Jetpack_Recommendations_Banner', 'ajax_callback' ) );
-
 		add_action( 'wp_loaded', array( $this, 'register_assets' ) );
 
 		/**
@@ -3342,8 +3340,6 @@ public function admin_init() {
 			Client::_wp_remote_request( self::connection()->api_url( 'test' ), $args, true );
 		}
 
-		Jetpack_Recommendations_Banner::init();
-
 		if ( current_user_can( 'manage_options' ) && ! self::permit_ssl() ) {
 			add_action( 'jetpack_notices', array( $this, 'alert_auto_ssl_fail' ) );
 		}