Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Node 18 compatibility #35

Merged
merged 7 commits into from
Jan 25, 2023
Merged

Fix Node 18 compatibility #35

merged 7 commits into from
Jan 25, 2023

Conversation

pyronaur
Copy link
Member

There's an incompatibility with the Jetpack Monorepo with Node 18 that caused this:

pnpm i
Scope: all 68 workspace projects
Lockfile is up to date, resolution step is skipped
Packages: +2439
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Packages are hard linked from the content-addressable store to the virtual store.
  Content-addressable store is at: /Users/a14/Library/pnpm/store/v3
  Virtual store is at:             node_modules/.pnpm
../../../Library/pnpm/store/v3/tmp/_tmp_5764_9532727db424d5de852132277deb98cc [jetpack-boost-critical-css-gen@0.0.4]: Running npm-install script, failed in 763ms
...5764_9532727db424d5de852132277deb98cc npm-install$ npm install
│ npm ERR! code EBADENGINE
│ npm ERR! engine Unsupported engine
│ npm ERR! engine Not compatible with your version of node/npm: @es-joy/jsdoccomment@0.10.8
│ npm ERR! notsup Not compatible with your version of node/npm: @es-joy/jsdoccomment@0.10.8
│ npm ERR! notsup Required: {"node":"^12 || ^14 || ^16"}
│ npm ERR! notsup Actual:   {"npm":"8.19.3","node":"v18.13.0"}
│ npm ERR! A complete log of this run can be found in:
│ npm ERR!     /Users/a14/.npm/_logs/2023-01-25T17_30_59_353Z-debug-0.log
└─ Failed in 763ms at /Users/a14/Library/pnpm/store/v3/tmp/_tmp_5764_9532727db424d5de852132277deb98cc
 ERR_PNPM_PREPARE_PACKAGE  Failed to prepare git-hosted package fetched from "https://codeload.github.com/automattic/jetpack-boost-critical-css-gen/tar.gz/91e0ed5e0cf6296fd06f525d1fc016d5d46af86f": jetpack-boost-critical-css-gen@0.0.4 npm-install: `npm install`
Exit status 1
Progress: resolved 2439, reused 2315, downloaded 0, added 144

npm why points to an outdated eslint-plugin-jsdoc dependency that's no longer compatible with Node 18:

npm why @es-joy/jsdoccomment@0.20.1
@es-joy/jsdoccomment@0.20.1 dev
node_modules/@wordpress/eslint-plugin/node_modules/@es-joy/jsdoccomment
  @es-joy/jsdoccomment@"~0.20.1" from eslint-plugin-jsdoc@37.9.7
  node_modules/@wordpress/eslint-plugin/node_modules/eslint-plugin-jsdoc
    eslint-plugin-jsdoc@"^37.0.3" from @wordpress/eslint-plugin@13.9.0
    node_modules/@wordpress/eslint-plugin
      dev @wordpress/eslint-plugin@"^13.9.0" from the root project

Overriding the version for now until we figure out a better way to deal with this.

@pyronaur pyronaur merged commit 799e6d7 into trunk Jan 25, 2023
@haqadn haqadn deleted the eslint-fix branch May 22, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant