Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): created a new rule that resolves #414 #455

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

elijah-potter
Copy link
Collaborator

I've created a new rule that should cover #414. From here, we mostly just need a couple more test cases.

You'll notice that I set it to be enabled by default in the LintGroup. If you disagree with this decision, let me know and I'd be happy to change it.

@elijah-potter elijah-potter added enhancement New feature or request rust Pull requests that update Rust code harper-core linting labels Jan 21, 2025
Copy link
Contributor

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM*

*I have 24 years experience in copy-paste and reverse engineering, and I think I could review your PR in Rust, while I have never coded any line of Rust

image

@hippietrail
Copy link
Contributor

You can check against this instance in the harper codebase in architecture/page.md

- [Parser](https://docs.rs/harper-core/latest/harper_core/parsers/trait.Parser.html): A trait that describes an object that consumes text and emits tokens. The name is somewhat of a misnomer since it is supposed to only lex English (and emit [Tokens](https://docs.rs/harper-core/latest/harper_core/struct.Token.html)), not parse it. It is called a parser since most types that implement this trait parse _other_ languages (JavaScript) to extract the English text.

I'm not submitting a PR to fix this one because "kids these days" almost certainly don't consider it an area. But you may of course choose to fix it if you wish (-:


By the way, is there an easy way to test this? I have a clone of the repo but I haven't attempted to build it yet because I hate build systems and every new project I play with these days has a new build system that entails a day or two down an unfun rabbithole when I could be doing fun OSS coding instead (-:

@elijah-potter
Copy link
Collaborator Author

By the way, is there an easy way to test this? I have a clone of the repo but I haven't attempted to build it yet because I hate build systems and every new project I play with these days has a new build system that entails a day or two down an unfun rabbithole when I could be doing fun OSS coding instead (-:

In #471, I've added a page that should explain some of this. Mind taking a look?

@hippietrail
Copy link
Contributor

#471

I must be a dummy but how do I get to the file to read it? No matter how I click on any link I can find from the PR link I'm only seeing things like diffs.

@elijah-potter elijah-potter merged commit cc21812 into master Jan 22, 2025
17 checks passed
@elijah-potter elijah-potter deleted the somewhat-something branch January 22, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request harper-core linting rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants