Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean Up harper-ls logs #447

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Clean Up harper-ls logs #447

merged 3 commits into from
Jan 21, 2025

Conversation

elijah-potter
Copy link
Collaborator

We've been seeing a lot of erroneous logs being made (see #443), cluttering buffers and making debugging more challenging. This PR aims to reduce this clutter by:

  1. Reducing the number of logs harper-ls produces.
  2. Reducing the noise within each log.

@elijah-potter elijah-potter added rust Pull requests that update Rust code harper-ls labels Jan 21, 2025
grantlemons
grantlemons approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@grantlemons grantlemons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, fyi we only have one call at warn level.

@grantlemons grantlemons mentioned this pull request Jan 21, 2025
Closed
@elijah-potter elijah-potter marked this pull request as ready for review January 21, 2025 20:21
@elijah-potter elijah-potter merged commit 1717342 into master Jan 21, 2025
4 checks passed
@elijah-potter elijah-potter deleted the reduce-error-logs branch January 21, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantlemons grantlemons grantlemons approved these changes

Assignees
No one assigned
Labels
harper-ls rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elijah-potter @grantlemons