Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Use H1 for header title and cover image caption #177

Merged
merged 7 commits into from
May 19, 2016
Merged

Use H1 for header title and cover image caption #177

merged 7 commits into from
May 19, 2016

Conversation

gemedet
Copy link
Contributor

@gemedet gemedet commented Apr 19, 2016

This allows markup inside the header title and cover image caption, e.g.:

<header>
    <figure>
        <figcaption>Some caption <i>in italic</i></figcaption>
    </figure>
    <h1>Some title <b>in bold</b></h1>
</header>

Follows facebookarchive/facebook-instant-articles-sdk-php#93

@gemedet gemedet changed the title Use H1 for cover image caption Use H1 for header title and cover image caption May 5, 2016
@everton-rosario everton-rosario merged commit ed25fc8 into Automattic:master May 19, 2016
@everton-rosario
Copy link
Collaborator

Hello @gemedet !
This was a nice catch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants