Remove deprecated rule

[mitogh]

Use the new rule:

• 'react/jsx-tag-spacing' in favor of 'react/jsx-space-before-closing'.

The rule is deprecated:

• https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-space-before-closing.md

And to avoid having notices of deprecation during the lint update with the new one.

[aduth]

Thanks for the change request.

Looking through the new options, I think we'd want to configure beforeClosing: 'never', given examples of "good" component render examples in the Calypso guidelines:

https://github.com/Automattic/wp-calypso/blob/master/docs/coding-guidelines/javascript.md#react-components

[mitogh]

Hey thanks for the follow up here @aduth, however I'm not really sure what the right call is as I don't think is very explicit on the guidelines.

However the previous (or current) rule uses always as parameter as that one is the default value for that property react/jsx-space-before-closing. So I think for consistency reasons always should be used for react/jsx-tag-spacing.

Let me know what you think.

Thanks.

[aduth]

Hey @mitogh , I think I misread the rule description the first time around. 'always' sounds like the correct option value.

[mitogh]

Thanks @aduth

That's the default value:

The default value of this option is "always".

On: https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-space-before-closing.md#rule-details

Do you think we need to specify explicitly anyways?

[aduth]

Nope, apologies for the confusion. This looks great as-is. Thanks!