Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait until the page is loaded before loading Chatrix #160

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Wait until the page is loaded before loading Chatrix #160

merged 1 commit into from
Jan 23, 2023

Conversation

akirk
Copy link
Member

@akirk akirk commented Jan 23, 2023

Through trial and error I determined that on a heavier page like https://make.wordpress.org/polyglots/ the block is not loaded unless you make it load after the load event.

@akirk akirk requested a review from psrpinto January 23, 2023 14:24
psrpinto
psrpinto approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@psrpinto psrpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

For reference here's an article explaining the difference between the load and DOMContentLoaded events.

@psrpinto psrpinto added this to the 0.5 milestone Jan 23, 2023
@akirk akirk merged commit 7c68521 into main Jan 23, 2023
@akirk akirk deleted the fix-loading-on-heavy-pages branch January 23, 2023 14:28
This was referenced Jan 23, 2023
Closed
Merged
@akirk akirk mentioned this pull request Jan 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psrpinto psrpinto psrpinto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@akirk @psrpinto