Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimum PHP version from 5.3.2 to 5.3.6 #1407

Merged
merged 2 commits into from
Sep 7, 2018
Merged

Update minimum PHP version from 5.3.2 to 5.3.6 #1407

merged 2 commits into from
Sep 7, 2018

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Sep 6, 2018 •
edited
Loading

The $node attribute for DOMDocument::saveHTML() was added in 5.3.6 (for some reason). So this is the required minimum version.

Fixes #1406.

Also updates PHP-CSS-Parser from upstream to include:

@westonruter westonruter added this to the v1.0 milestone Sep 6, 2018
@westonruter westonruter mentioned this pull request Sep 6, 2018
Closed
@westonruter westonruter merged commit a2cfdb9 into develop Sep 7, 2018
@westonruter westonruter deleted the update/php-min-version branch September 7, 2018 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@westonruter @swissspidy