-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use ems instead of pixels for media queries
- Loading branch information
Showing
2 changed files
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3761231
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See http://blog.cloudfour.com/the-ems-have-it-proportional-media-queries-ftw/
3761231
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, I've been using ems in my _s theme for some time now without issue.
3761231
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
÷
16 = 37.5625emCool, but what happens once the font size is changed?
Since theme is using Sass, can we do this instead: http://vvv.tobiassjosten.net/css/px-to-em-with-sass/
3761231
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it 100% sure that cloudfour article issue still exists in latest browsers? I've been moving back to using pixels in media queries and haven't noticed any issues.
3761231
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like an unconfirmed bug in WebKit browser https://bugs.webkit.org/show_bug.cgi?id=41063.
This was reported 4 years ago.