Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions/RestrictedFunctions: remove reference to function which doesn't exist #760

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Aug 22, 2023

PHP does not contain a delete() function, so searching for it will only yield false positives.

Ref: https://www.php.net/manual/en/function.delete.php

@jrfnl jrfnl added this to the 2.3.4 milestone Aug 22, 2023
@jrfnl jrfnl requested a review from a team as a code owner August 22, 2023 23:13
Copy link
Contributor

@GaryJones GaryJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not worried about any duplicates in test files, but I think the ruleset should avoid duplicate entries.

WordPress-VIP-Go/ruleset.xml Outdated Show resolved Hide resolved
…sn't exist

PHP does not contain a `delete()` function, so searching for it will only yield false positives.

Ref: https://www.php.net/manual/en/function.delete.php
@jrfnl jrfnl force-pushed the fix/remove-non-existent-function branch from 756b1a5 to 5a56060 Compare August 23, 2023 14:01
Copy link
Contributor

@GaryJones GaryJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating! ✅

@GaryJones GaryJones merged commit dbb81df into develop Aug 23, 2023
@GaryJones GaryJones deleted the fix/remove-non-existent-function branch August 23, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants