Composer: allow for the 1.0.0 version of the Composer PHPCS plugin #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Composer PHPCS plugin has released its 1.0.0 version. 🎉 Important: I've _widened_ the version constraints for the plugin, instead of _bumping_ it. The reason for this is to prevent conflicts with end-user projects/other external PHPCS standards which may also require(-dev) the plugin, but may not (yet) have updated _their_ constraints for the plugin. If the version would have been bumped instead of widened, those users would get an unsolvable conflict during the `composer install` run (unless they `require-dev` the plugin for the root project, but then, that's exactly what we _don't_ want them to do as external standards managing the versions of the plugins should be more reliable). The version constraints now set cover all released versions which support external standards properly. Ref: https://github.com/PHPCSStandards/composer-installer/releases/tag/v1.0.0
GaryJones
deleted the
feature/update-for-1.0-release-of-composer-phpcs-plugin
branch
|
Thanks for the fix! Is there a plan to release a stable version with these changes? It appears that the current diff is relatively small https://github.com/Automattic/VIP-Coding-Standards/compare/2.3.3..22733aa560f0f8855b848475770e4f800157e7f4 and contains mostly dev related changes. |
We're looking into that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Composer PHPCS plugin has released its 1.0.0 version. 🎉
Important:
I've widened the version constraints for the plugin, instead of bumping it.
The reason for this is to prevent conflicts with end-user projects/other external PHPCS standards which may also require(-dev) the plugin, but may not (yet) have updated their constraints for the plugin. If the version would have been bumped instead of widened, those users would get an unsolvable conflict during the
composer installrun (unless theyrequire-devthe plugin for the root project, but then, that's exactly what we don't want them to do as external standards managing the versions of the plugins should be more reliable).The version constraints now set cover all released versions which support external standards properly.
Ref: https://github.com/PHPCSStandards/composer-installer/releases/tag/v1.0.0