Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog to reflect 2.3.0 #662

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Update changelog to reflect 2.3.0 #662

merged 1 commit into from
Apr 19, 2021

Conversation

rebeccahum
Copy link
Contributor

I've left the breaking change in a note above the categories.

@rebeccahum rebeccahum requested a review from a team as a code owner April 15, 2021 17:57
@jrfnl jrfnl added this to the 2.3.0 milestone Apr 15, 2021
Copy link
Collaborator

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rebeccahum I realize that the previous changelogs have been quite perfunctory, so feel free to ignore my suggestions if you think it makes the changelog too wordy.

On top of the remarks I've left in-line, one other thing:
Numerous entries mention "Ruleset: ...", but these entries do not specify whether this applies to the WordPressVIPMinimum ruleset or the WordPress-VIP-Go ruleset or both. Might be prudent to mention that in each of those cases.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@rebeccahum rebeccahum merged commit f46177d into develop Apr 19, 2021
@rebeccahum rebeccahum deleted the 2.3.0-changelog branch April 19, 2021 14:33
@rebeccahum rebeccahum mentioned this pull request Apr 19, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants