Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable #620

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Silence VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable #620

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53469f5
Exclude VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable…
rebeccahum Jan 18, 2021
288159a
Silence rather than exclude for more user customization
rebeccahum Jan 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions WordPress-VIP-Go/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,9 +234,6 @@
<rule ref="VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedVariable">
<severity>3</severity>
</rule>
<rule ref="VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable">
<severity>1</severity>
</rule>
<rule ref="WordPressVIPMinimum.UserExperience.AdminBarRemoval">
<severity>3</severity>
</rule>
Expand All @@ -260,6 +257,9 @@
</rule>

<!-- Silence is golden, these don't affect us on VIP Go -->
<rule ref="VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable">
<severity>0</severity>
</rule>
<rule ref="WordPress.DB.SlowDBQuery.slow_db_query_meta_key">
<!-- We are silencing this one because VIP Go has a combined index on meta_key, meta_value-->
<severity>0</severity>
Expand Down