Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove second reference of WordPress.WP.AlternativeFunctions.curl_curl_getinfo #608

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Remove second reference of WordPress.WP.AlternativeFunctions.curl_curl_getinfo #608

merged 1 commit into from
Jan 8, 2021

Conversation

rebeccahum
Copy link
Contributor

We don't need two references of WordPress.WP.AlternativeFunctions.curl_curl_getinfo in the WordPressVIPMinimum ruleset.

@rebeccahum rebeccahum requested a review from a team as a code owner January 8, 2021 15:24
jrfnl
jrfnl approved these changes Jan 8, 2021
View reviewed changes
Copy link
Collaborator

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dear, I wonder how that even got in there ;-)

@jrfnl
Copy link
Collaborator

jrfnl commented Jan 8, 2021 •
edited
Loading

Merging - build failure is unrelated to this PR.

Make that: I recommend merging, without a code owner approval, I can't do it myself.

@rebeccahum rebeccahum merged commit 5f480bf into develop Jan 8, 2021
@rebeccahum rebeccahum deleted the rebecca/cleanup_-curl_curl_getinfo branch January 8, 2021 18:22
@jrfnl jrfnl added this to the 2.3.0 milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrfnl jrfnl jrfnl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rebeccahum @jrfnl