Ruleset Tests: Avoid issue with trigger_error() #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Judging between how https://travis-ci.org/github/Automattic/VIP-Coding-Standards/jobs/704661875 passed (for a different PR), and https://travis-ci.org/github/Automattic/VIP-Coding-Standards/jobs/704661876 failed (same, but with PHP 7.4snapshot), it looks like something changed with |
|
Once #484 is merged, then the final job should be re-run, as the curly brace in Config.php error was fixed in PHPCS 3.5.0 |
rebeccahum
previously approved these changes
Jul 3, 2020
For some reason, the presence of `trigger_error()` in our ruleset tests (either directly, or via the presence of `_deprecated_file()`, was breaking the tests.
GaryJones
force-pushed
the
fix/ruleset-tests
branch
from
2e74b9e to
2c30904
Compare
rebeccahum
approved these changes
Jul 3, 2020
This was referenced Jul 22, 2020
|
Reverted and fixed in #509. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the presence of
trigger_error()in our ruleset tests (either directly, or via the presence of_deprecated_file(), was breaking the tests.This should probably be looked at again to find the root cause, but this is a satisfactory work around for now.