Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AlwaysReturnSniff for missing return statement #291

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Fix AlwaysReturnSniff for missing return statement #291

merged 1 commit into from
Dec 4, 2018

Conversation

nickdaugherty
Copy link
Contributor

Now properly catches filter callbacks that don't return anywhere inside the function body

Fixes #290

@nickdaugherty
Fix AlwaysReturnSniff for missing return statement
7ad58f6 
Now properly catches filter callbacks that don't `return` _anywhere_ inside the function body
@tomjn tomjn merged commit c995a4e into master Dec 4, 2018
@GaryJones GaryJones deleted the fix/alwaysreturnsniff-with-no-return branch January 15, 2019 15:51
@jrfnl jrfnl mentioned this pull request Aug 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomjn tomjn tomjn approved these changes

Assignees
No one assigned
Labels
Status: Awaiting feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickdaugherty @tomjn