Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Claim profile button when Empty state in the profile card #563

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Remove the Claim profile button when Empty state in the profile card #563

merged 2 commits into from
Jan 28, 2025

Conversation

AdamGrzybkowski
Copy link
Contributor

Closes #553

Description

This PR removes the Claim profile button from the profile card when the state is Empty - meaning when the GA doesn't exist.

Screenshot 2025-01-27 at 14 52 52

Testing Steps

  1. Launch the Demo app
  2. Type in a random email that's not registered on Gravatar
  3. Launch the QE
  4. Confirm the "Claim profile" button is gone

@AdamGrzybkowski AdamGrzybkowski added Bug Something isn't working [Feature] Gravatar-Quickeditor Gravatar Quick Editor module labels Jan 27, 2025
@AdamGrzybkowski AdamGrzybkowski added this to the 2.3.0 milestone Jan 27, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 27, 2025 •
edited
Loading

📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
App Name Gravatar Demo
Commit8445a94
Direct Downloadgravatar-demo-prototype-build-pr563-8445a94.apk

mlumeau
mlumeau approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@mlumeau mlumeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm it's gone. 😉 LGTM!

@AdamGrzybkowski AdamGrzybkowski force-pushed the adam/553_claim_profile_button branch from ac4aa73 to 8445a94 Compare January 28, 2025 08:31
@AdamGrzybkowski AdamGrzybkowski merged commit a366224 into trunk Jan 28, 2025
17 checks passed
@AdamGrzybkowski AdamGrzybkowski deleted the adam/553_claim_profile_button branch January 28, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlumeau mlumeau mlumeau approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working [Feature] Gravatar-Quickeditor Gravatar Quick Editor module
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

Remove the "Claim profile"
3 participants
@AdamGrzybkowski @wpmobilebot @mlumeau