Guest author links should be filterable #204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebrandonallen
added a commit
to thebrandonallen/edit-author-slug
that referenced
this pull request
Jun 13, 2014
Loading our filter at a later time allows any links where the author actually exists in the users table to be filtered. Guest author links will remain unfiltered, i.e. - broken, until a solution is added in Co-Authors Plus. See [Automattic/Co-Authors-Plus#204] for the proposed fix.
thebrandonallen
added a commit
to thebrandonallen/edit-author-slug
that referenced
this pull request
Aug 13, 2014
Due to the way Co-Authors Plus filters 'author_link', a later filter priority is needed to still get our filters to work... at least partially. As long as the author link being generated is that of a legitimate WP user, one listed in the users table, we will still be able to successfully filter. However, guest authors will not have their links filtered until a fix upstream is applied. See Co-Authors-Plus PR #204 [Automattic/Co-Authors-Plus#204] for the proposed fix.
|
Closed in favor of #258 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With two small, but significant, exceptions, the code in
CoAuthors_Guest_Authors:filter_author_link()is the same as the function it's trying to filter,get_author_posts_url().The first difference, is where the
user_nicenameis set for guest authors. Without it, guest author links aren't appropriately created.The other difference, is the lack of the
author_linkfilter. Anyone trying to manipulate links returned byget_author_posts_url()or use a non-standard rewrite tag in WP_Rewrite::author_base, will find that they're filters fail. Found this while try to track down an issue a user was having with my Edit Author Slug plugin.This pull request keeps us DRY, and maintains the
author_linkfilter on guest authors.