EMSUSD-1504 prevent warnings when reloading the plugin #3959
+541
−507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move all resource to a Python dictionary. - This allows unregistering resources when unloaded.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-1504/reload-plugin-warnings
branch
from
a1d86cb
to
068062f
Compare
AramAzhari-adsk
previously approved these changes
Oct 15, 2024
pierrebai-adsk
added
ready-for-merge
seando-adsk
requested changes
Oct 15, 2024
|
Yes, that is a mistake. I must not have opened a window that depended on them when testing. I fill revert that part. |
The MEl version of localized strings for MayaUSdLib was lost. It is only used in the "Add Maya Reference" dialog and was not noticed during testing.
|
The reason I missed it is that they are only used in a single dialog: Add Maya Reference. Added them back and tested that window. Now it works again. |
AramAzhari-adsk
previously approved these changes
Oct 15, 2024
Also, reduce spam in one test due to trying to set-up up-axis when alredy the same axis.
seando-adsk
approved these changes
Oct 16, 2024
| @@ -50,9 +50,11 @@ def setUp(self): | |||
| """Clear the scene and setup the Maya preferences.""" | |||
| cmds.file(f=True, new=True) | |||
| # Make sure up-axis is Z. | |||
| cmds.upAxis(axis='z') | |||
| if cmds.upAxis(query=True, axis=True).lower() != 'z': | |||
There was a problem hiding this comment.
Do these occur when reloading the plugin?
There was a problem hiding this comment.
The commands were issuing warnings that the up-axis was already Z, I'm just reducing the amount of noise when running the tests.
AramAzhari-adsk
approved these changes
Oct 16, 2024
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use our own version of the function to register string resources to avoid spamming warning about duplicate resources.