EMSUSD-1613 clean session layer when undoing add prim #3955
+98
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Oct 10, 2024
pierrebai-adsk
commented
- Refactor the USD undo block and undo manager to support extending an undo item with new undos.
- Add a helper function to cleanup the session layer of a given prim data, capturing the removal in an undo item.
- Make the add-prim command use the session clean-up helper.
- Add unit test.
- Refactor the USD undo block and undo manager to support extending an undo item with new undos. - Add a helper function to cleanup the session layer of a given prim data, capturing the removal in an undo item. - Make the add-prim command use the session clean-up helper. - Add unit test.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-1613/clean-session-layer
branch
from
722fd29
to
0276593
Compare
AramAzhari-adsk
approved these changes
Oct 10, 2024
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
added
ufe-usd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.