EMSUSD-949 up axis in USD export #3935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Sep 26, 2024
pierrebai-adsk
commented
- Add "-upAxis" (-upa) option to the export command.
- Document it.
- Add upAxis to the export job arguments structure.
- Add upAxis and its possible values to the export tokens.
- Expose upAxis job arguments to Python.
- Add up axis UI to the export dialog.
- Add AutoUndoCommands class to execute and automatically undo a set of MEL commands.
- Use AutoUndoCommand to automatically change and restore the up-axis.
- Implement temporarily changing Maya up-axis. We rotate all root nodes 90 degrees before and after the export.
- We use undo so that the values are perfectly restored.
- Add unit test.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-949/axis-in-export
branch
from
e196428
to
7993964
Compare
- Add "-upAxis" (-upa) option to the export command. - Document it. - Add upAxis to the export job arguments structure. - Add upAxis and its possible values to the export tokens. - Expose upAxis job args to Python. - Add up axis UI to the export dialog. - Add AutoUndoCommands class to execute and automatically undo a set of MEL commands. - Use AutoUndoCommand to automatically change and restore the up-axis. - Implement temporarily changing Maya up-axis. We rotate all root nodes 90 degrees before and after the export. - We use undo so that the values are perfectly restored. - Add unit test.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-949/axis-in-export
branch
from
7993964
to
57b23cc
Compare
| @@ -212,7 +212,7 @@ def fileOptionsTabPage(tabLayout): | |||
| fileOptionsScroll = cmds.columnLayout('fileOptionsScroll') | |||
| optionsText = mayaUsdOptions.convertOptionsDictToText(cacheToUsd.loadCacheCreationOptions()) | |||
| optionsText = mayaUsdOptions.setAnimateOption(_mayaRefDagPath, optionsText) | |||
| mel.eval('mayaUsdTranslatorExport("fileOptionsScroll", "post={exportOpts}", "{cacheOpts}", "")'.format(exportOpts=kTranslatorExportOptions, cacheOpts=optionsText)) | |||
| mel.eval('mayaUsdTranslatorExport("fileOptionsScroll", "post={exportOpts};cacheToUSD", "{cacheOpts}", "")'.format(exportOpts=kTranslatorExportOptions, cacheOpts=optionsText)) | |||
There was a problem hiding this comment.
Hi Pierre. I wonder why is this change needed?
There was a problem hiding this comment.
So that the export UI knows that it is being call for caching to USD and disable some UI element.
samuelliu-adsk
previously approved these changes
Sep 27, 2024
pierrebai-adsk
added
the
ready-for-merge
minor - typo
|
I fixed a minor typo in the .md. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.