EMSUSD-949 up axis in USD export #3930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Sep 25, 2024
pierrebai-adsk
commented
- Add "-upAxis" (-upa) option to the export command.
- Document it.
- Add upAxis to the export job arguments structure.
- Add upAxis and its possible values to the export tokens.
- Expose upAxis job arguments to Python.
- Add up axis UI to the export dialog.
- Implement temporarily changing Maya up-axis. We rotate all root nodes 90 degrees before and after the export.
- Add unit test.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-949/axis-in-export
branch
from
9378dd3
to
46aef0e
Compare
pierrebai-adsk
commented
Sep 26, 2024
lib/mayaUsd/fileio/jobs/writeJob.cpp
Outdated
| @@ -112,6 +112,112 @@ static TfToken _GetFallbackExtension(const TfToken& compatibilityMode) | |||
| return UsdMayaTranslatorTokens->UsdFileExtensionDefault; | |||
| } | |||
|
|
|||
| class AutoUpAxisChanger | |||
There was a problem hiding this comment.
This is how change of axis during export is done: we temporarily rotate the Maya scene so that we can rely on the existing correct behavior already written in Maya to handle all possible nodes properly.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-949/axis-in-export
branch
from
46aef0e
to
e3aad9d
Compare
- Add "-upAxis" (-upa) option to the export command. - Document it. - Add upAxis to the export job arguments structure. - Add upAxis and its possible values to the export tokens. - Expose upAxis job args to Python. - Add up axis UI to the export dialog. - Add AutoUndoCommands class to exeucte and automatically undo a set of MEL commands. - Use AutoUndoCommand to automatically change and reatore the up-axis. - Implement temporarily changing Maya up-axis. We rotate all root nodes 90 degrees before and after the export. - We use undo so that the values are perfectly restored. - Add unit test.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-949/axis-in-export
branch
from
e3aad9d
to
ec5a45a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.