EMSUSD-612 - Update topo node list #3322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MaterialX topological node list was in need of an update:
For MaterialX 1.38.7:
"dot" nodes are now topological.
Via AcademySoftwareFoundation/MaterialX#1152
For upcoming MaterialX 1.38.8:
"dot" node no longer elided (except for filenames)
"switch" node no longer elided
Via AcademySoftwareFoundation/MaterialX#1522
| float inputs:specular = 1 | ||
| float inputs:specular_roughness = 0.2 | ||
| token outputs:out | ||
| } | ||
|
|
||
| def Shader "red" |
There was a problem hiding this comment.
Will render black without the update to the topo list.
JGamache-autodesk
added
the
ready-for-merge
|
@seando-adsk Ready for merge. |
seando-adsk
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MaterialX topological node list was in need of an update:
For MaterialX 1.38.7:
"dot" nodes are now topological.
Via AcademySoftwareFoundation/MaterialX#1152
For upcoming MaterialX 1.38.8:
"dot" node no longer elided (except for filenames) "switch" node no longer elided
Via AcademySoftwareFoundation/MaterialX#1522