Mac port for windows only functionality #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewaldbr2
approved these changes
Jun 20, 2023
ewaldbr2
approved these changes
Jun 20, 2023
martinweismann
changed the title
martinweismann
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the need for manual editing of files generated for both Mac and Windows so that my Windows project compiles.
Perhaps controversially, I added
nameIsValidEnumOptionIdentifierto allow ACT to accept enum identifiers which begin with a lowercase letter. I also allowed descriptions to be proceeded by a space. We'll want to revert these things in the medium term and fix in the xml generation code instead.