Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a player is not registered then we send a LOGIN plugin message on join #2275

Merged
merged 3 commits into from
Aug 30, 2021

Conversation

bundabrg
Copy link
Contributor

@bundabrg bundabrg commented Feb 3, 2021

Presently when AuthMeBungee is used and requireAuth is set to true a player needs to login before doing anything.

This will allow players who are not registered (have no password) to be treated as if they are logged in by broadcasting the LOGIN message.

This means that players who are registered will be required to login and will be unable to execute any command either on the server or on the proxy, and those who are not registered will still be able to play without needing to register.

This prevents an issue where a forcedLogin of a player that doesn't exist occurring when an unregistered player switches a server. The first login would tell AuthBungee that the player is logged in, and subsequent switches would have AuthBungee send a performLogin back that would then send an unregistered player error message to the player.
@sgdc3
Copy link
Member

sgdc3 commented Apr 8, 2021

AuthMe/AuthMeBungee#54

@sgdc3 sgdc3 merged commit 80e3757 into AuthMe:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants