Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Protocol: Call of Duty: Modern Warfare 2 #626

Merged
merged 8 commits into from
May 27, 2022
Merged

Add Protocol: Call of Duty: Modern Warfare 2 #626

merged 8 commits into from
May 27, 2022

Conversation

bumbummen99
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented May 23, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 88.146% when pulling 825d146 on feature-protocol-codmw2 into 0487741 on v3.

Patrick and others added 2 commits May 23, 2022 22:03
Update Codmw2.php
4215b59 
Fix remove last empty player
@bumbummen99
Regenerate test data and fix protocol players
825d146 
Signed-off-by: Patrick Henninger <privat@skyraptor.eu>
@bumbummen99 bumbummen99 marked this pull request as draft May 23, 2022 20:16
@scrutinizer-notifier
Copy link

The inspection completed: 2 updated code elements

@bumbummen99 bumbummen99 added the Enhancement This request does add something to the project. label May 26, 2022
@bumbummen99 bumbummen99 requested a review from Austinb May 26, 2022 18:37
@bumbummen99 bumbummen99 changed the title Call of Duty: Modern Warfare 2 Protocol: Call of Duty: Modern Warfare 2 May 26, 2022
@bumbummen99 bumbummen99 changed the title Protocol: Call of Duty: Modern Warfare 2 Add Protocol: Call of Duty: Modern Warfare 2 May 26, 2022
@Austinb Austinb marked this pull request as ready for review May 27, 2022 01:19
Austinb
Austinb approved these changes May 27, 2022
View reviewed changes
Copy link
Owner

@Austinb Austinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and checks pass. Thanks for the help on this.

@Austinb Austinb merged commit 64f7bf3 into v3 May 27, 2022
@Austinb Austinb deleted the feature-protocol-codmw2 branch February 25, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Austinb Austinb Austinb approved these changes

Assignees

@bumbummen99 bumbummen99

Labels
Enhancement This request does add something to the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bumbummen99 @coveralls @scrutinizer-notifier @Austinb