-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Samp add server by domain #593
Conversation
It should resolve to IP over here the input to the method being the Line 162 in af6641c
|
Fix stub in isse 588 test,
The inspection completed: No new issues |
@Austinb Done. This is not a breaking change tho i would suggest a minor version since this will change the host and join url in the result to now, correctly, be the IP as it was originally intended in GameQ\Server.php. |
Related #588
We do fail at the following line:
GameQ/src/GameQ/Protocols/Samp.php
Line 129 in af6641c
It simply does expect an IP and not a domain