Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade black for new remote-dev boxes #2900

Merged
merged 7 commits into from
Apr 13, 2022
Merged

Upgrade black for new remote-dev boxes #2900

merged 7 commits into from
Apr 13, 2022

Conversation

joaquincasares
Copy link
Contributor

Description

We are seeing this with new remote-dev boxes:

Traceback (most recent call last):
  File "/home/ubuntu/.cache/pre-commit/repoc0u0pk8f/py_env-python3/bin/black", line 8, in <module>
    sys.exit(patched_main())
  File "/home/ubuntu/.cache/pre-commit/repoc0u0pk8f/py_env-python3/lib/python3.8/site-packages/black/__init__.py", line 1372, in patched_main
    patch_click()
  File "/home/ubuntu/.cache/pre-commit/repoc0u0pk8f/py_env-python3/lib/python3.8/site-packages/black/__init__.py", line 1358, in patch_click
    from click import _unicodefun
ImportError: cannot import name '_unicodefun' from 'click' (/home/ubuntu/.cache/pre-commit/repoc0u0pk8f/py_env-python3/lib/python3.8/site-packages/click/__init__.py)

-- pallets/click#2225

Tests

rm ~/.cache/pre-commit
git commit README.md

How will this change be monitored? Are there sufficient logs?

@joaquincasares
Copy link
Contributor Author

@csjiang in order for this PR to pass, we need to rebuild remote-dev with the newest version of black.

New remote-dev boxes won't be able to run pre-commit hooks until this PR is in.

If other dev environments do not auto-upgrade black, then they need to run:

rm ~/.cache/pre-commit

@csjiang
Copy link
Contributor

csjiang commented Apr 12, 2022

@joaquincasares gotcha on the remote dev stuff but i think to get PR to pass CI checks is just fixing the spacing w the operator on those two extra files right?

i'll rebake remote dev after this goes into master to get ahead of the pre-commit stuff, but can we fix those two files so this PR can be merged?

@joaquincasares
Copy link
Contributor Author

Sounds good!

I'll ping you when this is merged and then open up a second PR.

Thanks!

@csjiang csjiang merged commit 4d67b5c into master Apr 13, 2022
@csjiang csjiang deleted the jc-asi-983.lint branch April 13, 2022 14:56
@AudiusProject AudiusProject deleted a comment from linear bot Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants