[C-5828] Fix useQueries default loading state #11569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
schottra
added a commit
that referenced
this pull request
Mar 11, 2025
* origin/main: Remove prop in PlayCountMilestoneContent causing type error (#11575) dual write to acdc and core (#11573) [C-5828] Fix useQueries default loading state (#11569) fix attest endpoint (#11552) Fix unlocked gated content section on web (#11568) Remove end_date on play count challenge and update query (#11563)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where useQueries when provided "empty" array results in isPending = false, leading to issues where hooks that use
useUsersas part of their data fetching flow have invalid isPending state during the handoff from the first api call to the useUsers call.The fix is to decorate the tan-query useQueries hook with our special version that sets isPending = true for the one render cycle while the useQueries hook is transitioning from the empty state.
Also updates our types for combine-query-statuses, which allows us to get rid of annoying type-casts.