Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix embed node polyfills and clean up deps #11535

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Fix embed node polyfills and clean up deps #11535

merged 1 commit into from
Mar 6, 2025

Conversation

schottra
Copy link
Contributor

@schottra schottra commented Mar 6, 2025

Description

The built bundle for embed is having some issues with the Buffer node polyfill. It doesn't cause a problem in dev when serving from vite, but does throw errors about Buffer when built and deployed.
image

Bonus: Also removed the libs reference that I'm not sure why we still had here (nothing in embed calls into libs)

How Has This Been Tested?

Built bundle and deployed to a test CF worker, was able to load a collectibles embed that had previously thrown.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2025

⚠️ No Changeset found

Latest commit: 4c3aa05

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

raymondjacobson
raymondjacobson approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@raymondjacobson raymondjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

raymondjacobson
raymondjacobson approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@raymondjacobson raymondjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

packages/embed/package.json
@@ -37,7 +39,6 @@
"@audius/fixed-decimal": "*",
"@audius/harmony": "*",
"@audius/sdk": "*",
"@audius/sdk-legacy": "*",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hahhaa

@schottra schottra enabled auto-merge (squash) March 6, 2025 22:15
dylanjeffers
dylanjeffers approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff

@schottra schottra merged commit e964d98 into main Mar 6, 2025
7 checks passed
@schottra schottra deleted the fix-collectibles-embed branch March 6, 2025 22:27
@schottra schottra mentioned this pull request Mar 6, 2025
Merged
schottra added a commit that referenced this pull request Mar 7, 2025
@schottra
Fix embed node polyfills and clean up deps (#11535)
5608f28
dylanjeffers added a commit that referenced this pull request Mar 11, 2025
@dylanjeffers
Audius Client (Web and Mobile) v1.5.125
9716a3b 
            [41279da] [PAY-3992] Improve suggested follows loading (#11543) Raymond Jacobson
[2791db8] [PAY-3699] Show upload chip if you have deleted all your tracks (#11518) Raymond Jacobson
[2b2b1db] Hotfix advanced search filters not working (#11554) JD Francis
[3abf343] Fix useDeleteTrack, sagas,  and confirmation modal (#11553) Andrew Mendelsohn
[42323a7] [C-5826] Add combineQueryStatuses helper (#11551) Dylan Jeffers
[5c389a4] [C-5759] DeleteTrack to tan-query (#11510) Andrew Mendelsohn
[00cc46f] Fix now playing artwork visualizer button (#11540) Dylan Jeffers
[3a26024] Revert "[PAY-3865] Don't deeplink on android oauth" (#11549) Farid Salau
[073188c] Fix now playing jitter and nav icon spacing in mobile web (#11548) Raymond Jacobson
[fe74995] Add breakpoint on rewards banner (#11547) Farid Salau
[830eefb] Update collectibles modal UI (#11544) Dylan Jeffers
[713f9bf] Use paper component (#11539) Farid Salau
[6cbb273] Make banner closer to figma (#11537) Farid Salau
[e964d98] Fix embed node polyfills and clean up deps (#11535) Randy Schott
[e9f96fc] Fix banner on mobile web (#11534) Farid Salau
[cb9e17a] [PAY-3782] Update reward banners (#11533) Farid Salau
[1c24bec] Search pagination (#11458) Steve Perkins
[f50c813] [QA-2003] Fix overflow menu share (#11524) Dylan Jeffers
[8e859a7] [C-5804] Improve notification panel ui (#11488) Dylan Jeffers
[b796369] [C-5821] Recent comments final QA (#11514) Dylan Jeffers
[1ec2871] Remove unused notification data fields from sdk (#11515) Randy Schott
[b2cf065] Revert "[C-5204] Fix android comment input clipping (#11386)" (#11513) Dylan Jeffers
[ae7c5c6] [C-5820] Update trending rewards modal UI (#11504) Dylan Jeffers
[f0f3867] [PAY-3947] Fix challenge error UI (#11507) Reed
[d898567] [PAY-3983] Fix missing status label on reward panels (#11506) Reed
[327e915] Enable stage AAO plugin config (#11502) Isaac Solo
[315cb3d] [PAY-3985] More misc first weekly comment challenge UI fixes (#11503) Reed
[09c6315] Misc first weekly comment challenge fixes (#11501) Reed
[e0320a3] fix max width for flex page container (#11500) Randy Schott
[2ccc863] Update trending modal header (#11498) Farid Salau
[1ec0e29] Fix first comment status label (#11496) Reed
[1d29d3d] Add some challenge icons back (#11495) Reed
[c200c7a] Fix trending page (#11494) Farid Salau
[57f296a] Update trending copy and challenge config (#11493) Farid Salau
[f4ee993] [C-5738] favoriteTrack and unfavoriteTrack to tan-query (#11431) Andrew Mendelsohn
[69e690f] [PAY-3975] First weekly comment mobile UI (#11489) Reed
@dylanjeffers dylanjeffers mentioned this pull request Mar 11, 2025
Merged
dylanjeffers added a commit that referenced this pull request Mar 11, 2025
@dylanjeffers
Audius Client (Web and Mobile) v1.5.125 (#11582)
b231754 
[41279da] [PAY-3992] Improve suggested follows loading (#11543) Raymond Jacobson
[2791db8] [PAY-3699] Show upload chip if you have deleted all your tracks (#11518) Raymond Jacobson
[2b2b1db] Hotfix advanced search filters not working (#11554) JD Francis
[3abf343] Fix useDeleteTrack, sagas,  and confirmation modal (#11553) Andrew Mendelsohn
[42323a7] [C-5826] Add combineQueryStatuses helper (#11551) Dylan Jeffers
[5c389a4] [C-5759] DeleteTrack to tan-query (#11510) Andrew Mendelsohn
[00cc46f] Fix now playing artwork visualizer button (#11540) Dylan Jeffers
[3a26024] Revert "[PAY-3865] Don't deeplink on android oauth" (#11549) Farid Salau
[073188c] Fix now playing jitter and nav icon spacing in mobile web (#11548) Raymond Jacobson
[fe74995] Add breakpoint on rewards banner (#11547) Farid Salau
[830eefb] Update collectibles modal UI (#11544) Dylan Jeffers
[713f9bf] Use paper component (#11539) Farid Salau
[6cbb273] Make banner closer to figma (#11537) Farid Salau
[e964d98] Fix embed node polyfills and clean up deps (#11535) Randy Schott
[e9f96fc] Fix banner on mobile web (#11534) Farid Salau
[cb9e17a] [PAY-3782] Update reward banners (#11533) Farid Salau
[1c24bec] Search pagination (#11458) Steve Perkins
[f50c813] [QA-2003] Fix overflow menu share (#11524) Dylan Jeffers
[8e859a7] [C-5804] Improve notification panel ui (#11488) Dylan Jeffers
[b796369] [C-5821] Recent comments final QA (#11514) Dylan Jeffers
[1ec2871] Remove unused notification data fields from sdk (#11515) Randy Schott
[b2cf065] Revert "[C-5204] Fix android comment input clipping (#11386)" (#11513) Dylan Jeffers
[ae7c5c6] [C-5820] Update trending rewards modal UI (#11504) Dylan Jeffers
[f0f3867] [PAY-3947] Fix challenge error UI (#11507) Reed
[d898567] [PAY-3983] Fix missing status label on reward panels (#11506) Reed
[327e915] Enable stage AAO plugin config (#11502) Isaac Solo
[315cb3d] [PAY-3985] More misc first weekly comment challenge UI fixes (#11503) Reed
[09c6315] Misc first weekly comment challenge fixes (#11501) Reed
[e0320a3] fix max width for flex page container (#11500) Randy Schott
[2ccc863] Update trending modal header (#11498) Farid Salau
[1ec0e29] Fix first comment status label (#11496) Reed
[1d29d3d] Add some challenge icons back (#11495) Reed
[c200c7a] Fix trending page (#11494) Farid Salau
[57f296a] Update trending copy and challenge config (#11493) Farid Salau
[f4ee993] [C-5738] favoriteTrack and unfavoriteTrack to tan-query (#11431) Andrew Mendelsohn
[69e690f] [PAY-3975] First weekly comment mobile UI (#11489) Reed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raymondjacobson raymondjacobson raymondjacobson approved these changes

@dylanjeffers dylanjeffers dylanjeffers approved these changes

@rickyrombo rickyrombo Awaiting requested review from rickyrombo

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schottra @raymondjacobson @dylanjeffers