Remove invalid model fields for create track/playlist notifs #11511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
raymondjacobson
approved these changes
Mar 5, 2025
audius-infra
pushed a commit
that referenced
this pull request
Mar 5, 2025
[d05de12] Fix missing cover-photo error log (#11512) Raymond Jacobson [3c02192] Remove invalid model fields for create track/playlist notifs (#11511) Randy Schott [e4056ed] Make stage first weekly comment backend match prod (#11508) Reed [ed24d42] Use cross fetch in AAO plugin (#11505) Isaac Solo [327e915] Enable stage AAO plugin config (#11502) Isaac Solo [18a5dea] AAO UI (#11499) Steve Perkins [3656b57] indexing side effects (#11492) alecsavvy [1ec83cc] [PAY-3954] Add backend for play count challenge (#11473) Farid Salau
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will take care of the endless stream of model marshalling error messages. These two fields don't exist on the notification data that we get back from queries. While we could try to make the marshaller accept missing fields where
Noneis an option, this is safer for now. There fields don't appear to be in use anywhere on the client.How Has This Been Tested?
Local stack and client. Created 2 users, user B follows user A. User A creates a new track. Verified we no longer see error logs for bad marshalling.