Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C-5811] Refactor comment hooks and update adapter #11482

Merged
merged 5 commits into from
Feb 28, 2025

Conversation

dylanjeffers
Copy link
Contributor

Description

comments.ts file was getting a bit large so moved each hook into a separate file.
Updated the comment adapter to decode the entityId so we can use it directly in useTrack calls.

Copy link

changeset-bot bot commented Feb 27, 2025

⚠️ No Changeset found

Latest commit: b5a3edf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

const queryClient = useQueryClient()
const dispatch = useDispatch()

const queryRes = useQuery({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be updated to follow the batching pattern that we use now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm i see

Copy link
Contributor

@Kyle-Shanks Kyle-Shanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great refactor

@dylanjeffers dylanjeffers merged commit ccbc330 into main Feb 28, 2025
3 of 5 checks passed
@dylanjeffers dylanjeffers deleted the c-5811-comment-hooks-refactor branch February 28, 2025 21:01
audius-infra pushed a commit that referenced this pull request Mar 1, 2025
[8de3918] [C-5816] Finalize UI (#11487) Dylan Jeffers
[f0aac88] [C-5807] Add comment normalization (#11484) Dylan Jeffers
[09b70a9] [C-5798] Add enter animation to recent-comments (#11485) Dylan Jeffers
[ccbc330] [C-5811] Refactor comment hooks and update adapter (#11482) Dylan Jeffers
[ecba6fe] [C-5812] Revert the TextLink display change and add drawer open event for recent comments drawer on mobile (#11486) KJ
[a882224] [C-5806] Add analytics for recent comments (#11481) KJ
[138921a] [C-5799] Add comment related entities (#11475) Dylan Jeffers
[6d463a9] [C-5797] Implement Recent comments drawer (#11477) Randy Schott
[62edd03] Fix width for track page (#11480) Randy Schott
[d2dfd5a] [PAY-3972] First weekly comment challenge web UI (#11478) Reed
[84daddc] Web referral challenge UI updates (#11476) Reed
[a0b3da0] Fix audio matching challenge web progress status UI (#11471) Reed
[e46a49a] Update copy on purchase flow (#11469) Farid Salau
[7ccc030] Fix challenge claiming on web (#11468) Reed
[b4b559a] [C-5794] Migrate search autocomplete to tan-query (#11432) Dylan Jeffers
[23ea12e] [C-5800] Recent comments QA 1 (#11450) KJ
[796667c] Fix user list crash on null handle (#11447) Andrew Mendelsohn
[f1334ab] Fix gutters for profile page (#11456) Randy Schott
[06a0260] Remove airdrop banner (#11455) Raymond Jacobson
[26e5615] fix typecheck on main (#11449) Andrew Mendelsohn
[ad1b826] [PAY-3940] Listen streak reminder mobile notif analytics (#11446) Reed
[4e75f5d] Fix comment history page infinite loading (#11443) KJ
[d6f349d] [PAY-3958] Make updates to audio match rewards (#11445) Farid Salau
[ae22d35] [C-5780][C-5781][C-5793] Adds recent comments section to profile page/screen (#11439) Randy Schott
[310fb6c] Fix email decryption for backfilled emails (#11437) Farid Salau
[0927277] Mobile challenge UI refactor (#11440) Reed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants